Disable OpenSSL by default#1086
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Mar 9, 2015
Merged
Conversation
Contributor
|
LGTM Reducing the number of dependencies is always a good thing 👍 |
A while back, we found that using OpenSSL's SHA-1 implementation rather than our usual one resulted in a significant speedup of maketx. I've done some retimings, now that a lot else has changed about maketx's internals (including adopting the practice of hashing blocks of scanlines, making it amenable to multithreading), and found that the speedup we get by using OpenSLL's SHA-1 is barely measurable. The minuscule speedup doesn't seem worth the trouble of imposing OpenSSL as a dependency. In light of this, I propose this patch to change the default to using the SHA-1 implementation that's compiled in, thus removing OpenSSL as a dependency. Now it's still an option, mainly so I can continue to compare the two methods. But it's possible that in the future, we may remove the potential for using OpenSSL altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while back, we found that using OpenSSL's SHA-1 implementation rather than our usual one resulted in a significant speedup of maketx.
I've done some retimings, now that a lot else has changed about maketx's internals (including adopting the practice of hashing blocks of scanlines, making it amenable to multithreading), and found that the speedup we get by using OpenSLL's SHA-1 is barely measurable. The minuscule speedup doesn't seem worth the trouble of imposing OpenSSL as a dependency.
In light of this, I propose this patch to change the default to using the SHA-1 implementation that's compiled in, thus removing OpenSSL as a dependency.
Now it's still an option, mainly so I can continue to compare the two methods. But it's possible that in the future, we may remove the potential for using OpenSSL altogether.