Fix include for gcc 4.7.#207
Closed
hobbes1069 wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom
hobbes1069:gcc47
Closed
Fix include for gcc 4.7.#207hobbes1069 wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom hobbes1069:gcc47
hobbes1069 wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom
hobbes1069:gcc47
Conversation
Collaborator
|
LGTM, I will merge it. |
Contributor
|
For visual studio / windows, unistd.h is not available, but sys/types.h is portable and seems like it would solve this issue. |
Collaborator
|
I was just wondering what effect this would have on Windows. I'll switch to sys/types.h instead. Safe everywhere? |
Collaborator
|
Merged. |
Contributor
Author
|
Yup, worked for me too :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like "off_t" is no longer gotten for free so unistd.h must be explicitly included.