Jpeg2000 read/write image fix#213
Closed
robert-matusewicz wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom
robert-matusewicz:jpeg_save_image_fix
Closed
Jpeg2000 read/write image fix#213robert-matusewicz wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom robert-matusewicz:jpeg_save_image_fix
robert-matusewicz wants to merge 1 commit intoAcademySoftwareFoundation:masterfrom
robert-matusewicz:jpeg_save_image_fix
Conversation
… when TypeDesc is (U)INT8
Collaborator
|
Are there signed 8 bit J2K's out there? If you look at jpeg2000input.cpp, line 202, we can't possibly set the format to INT8. But in some sense, that is where the real bug is (if there are INT8 JPEG's). So your new code can't change any behavior. There is a similar bug in jpeg2000output.cpp, where I think it won't behave properly if the user passes a non-UINT8, non-UINT16 buffer. I think the lines you changed are just one part of the chain of events that needs to be fixed. |
Author
|
Ah, thats good points, now I'm not sure why I prepared this pull request, brobably was tired when writing this code:) I close this pull request and prepare other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TypeDesc is set to INT8 plugin should save 8-bit data to the file, not 16-bit (read_scanlin write_scanline should be typed to uint8_t).
Run the testsuite and this patch don't broke anything.