Review: tinyformat fixes

[lgritz]

Needed some other tweaks to work well with OSL (and presumably other clients).

[fpsunflower]

LGTM

[c42f]

On Thu, Apr 19, 2012 at 8:03 AM, Larry Gritz
reply@reply.github.com
wrote:

Needed some other tweaks to work well with OSL (and presumably other clients).

There's one thing I don't understand about your use of
TINYFORMAT_WRAP_FORMAT here Larry: why the static? The expression

TINYFORMAT_WRAP_FORMAT (static std::string, format, /**/,
std::ostringstream msg;, msg, return msg.str();)

Expands to a set of functions in which there is two distinct kinds of
things. The no-args version is

inline static std::string format(const char* fmt)
{
    std::ostringstream msg;
    tinyformat::format(msg, fmt);
    return msg.str();
}

the verions with more than one argument are templates:

template<typename T1>
static std::string format(const char* fmt, const T1& v1)
{
    std::ostringstream msg;
    tinyformat::format(msg, fmt, v1);
    return msg.str();
}

What I'd like to understand is why these the static keyword is
reqired: I would have thought "inline static" is a contradiction
(inline and static linkage are just different, and mutually
incompatible); template functions have inline linkage by default so I
guess declaring them static might be meaningful, but I don't
understand the need.

~Chris

[lgritz]

Mistake?

Chris Foster reply@reply.github.com wrote:

On Thu, Apr 19, 2012 at 8:03 AM, Larry Gritz
reply@reply.github.com
wrote:

Needed some other tweaks to work well with OSL (and presumably other
clients).

There's one thing I don't understand about your use of
TINYFORMAT_WRAP_FORMAT here Larry: why the static? The expression

TINYFORMAT_WRAP_FORMAT (static std::string, format, /**/,
std::ostringstream msg;, msg, return msg.str();)

Expands to a set of functions in which there is two distinct kinds of
things. The no-args version is

inline static std::string format(const char* fmt)
{
std::ostringstream msg;
tinyformat::format(msg, fmt);
return msg.str();
}

the verions with more than one argument are templates:

template
static std::string format(const char* fmt, const T1& v1)
{
std::ostringstream msg;
tinyformat::format(msg, fmt, v1);
return msg.str();
}

What I'd like to understand is why these the static keyword is
reqired: I would have thought "inline static" is a contradiction
(inline and static linkage are just different, and mutually
incompatible); template functions have inline linkage by default so I
guess declaring them static might be meaningful, but I don't
understand the need.

~Chris

---

Reply to this email directly or view it on GitHub:
#328 (comment)

Larry Gritz
lg@larrygritz.com

[c42f]

I was assuming there was something very subtle concerning linkage which I didn't understand :)

Ah, maybe I see what happened - did you copy the usage from ustring.h ? I made the same mistake there when I was converting the static ustring::format function.

Hold on, I'll make a little patch to fix both occurrences of this oddity.

[lgritz]

Yes, that's exactly what happened.

Chris Foster reply@reply.github.com wrote:

I was assuming there was something very subtle concerning linkage which
I didn't understand :)

Ah, maybe I see what happened - did you copy the usage from ustring.h ?
I made the same mistake there when I was converting the static
ustring::format function.

Hold on, I'll make a little patch to fix both occurrences of this
oddity.

---

Reply to this email directly or view it on GitHub:
#328 (comment)

Larry Gritz
lg@larrygritz.com