Review: Fix or suppress warnings with clang (redux)#329
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Apr 18, 2012
Merged
Review: Fix or suppress warnings with clang (redux)#329lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
Conversation
src/CMakeLists.txt
Outdated
Contributor
There was a problem hiding this comment.
Can't you remove all those warning flags now that -isystem is working?
Collaborator
Author
There was a problem hiding this comment.
Good question, I'll see how many I can remove. Stay tuned.
Collaborator
Author
There was a problem hiding this comment.
I was able to remove two more of these. One more is for pugi, another for our code (and I'm not sure I want to change it without more thought, despite the warning).
Collaborator
Author
|
We still have one big warning: the Cineon stuff. I was looking at it, and I think it's a bug, involved enough that I want to review a fix separately. |
Contributor
|
LGTM I'm fine with removing the remaining flags as separate reviews. Hopefully we can turn on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of "fix or suppress warnings with clang." Fewer warnings suppressed, better way of telling clang to ignore warnings in boost.