Review: Over (Stefan Stavrev, with minor mods by LG)#390
Merged
lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom Jun 28, 2012
Merged
Review: Over (Stefan Stavrev, with minor mods by LG)#390lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom
lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom
Conversation
* Lots of documenting comments. * Some minor formatting changes or other small changes for clarity in some places. * Move parallel_image to imagebufalgo.h and change slightly to remove the need for the R parameter entirely. I think that makes it even more generally useful. * Add testsuite/oiiotool-composite * Fix oiiotool default threads to correctly be hardware concurrency.
Collaborator
Author
|
If you click on the link for the second commit, you can see just what I changed in Stefan's code. It's fairly minor. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
lgritz
added a commit
that referenced
this pull request
Jun 28, 2012
ImageBufAlgo::over() Porter/Duff compositing operation and oiiotool --over by Steven Stavrev (with minor LG mods)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Stefan Stavrev's work, after I've squashed it and applied a few minor modifications on top of it. To wit:
I'm posting this review only to make it easy for Stefan and Chris Foster (and others, if interested) to look it over one more time, with both my and Stefan's changes together, before I do a final merge into the development master.
Stefan's original pull request is here: #381