Review: Kevin Brightwell's error checking and warning fixes#413
Merged
Review: Kevin Brightwell's error checking and warning fixes#413
Conversation
Closed
Collaborator
Author
|
OK, since this passes tests, I'm going to merge it. Cross fingers. |
* Many cases where we were ignoring the results of fread or fwrite, so now we religiously check the results and set errors appropriately (this affected bmp, fits, ico, jpeg2000, sgi, targa, tiff, webp, zfile). * Some unused variables. This work was mostly Kevin Brightwell, with a cleanup pass by Larry Gritz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a squash and minor cleanup of #396. LG fixed a few bugs and rearranged the parameter ordering of those fread/fwrite helper functions (to match the built-in one, less confusing that way). It changed enough that I thought it worth showing everybody before a commit. I couldn't amend Kevin's pull request, so I just submitted another, but this is really just a revision of that request.
Here's the final log entry:
Fix many compiler warnings and beef up I/O error checking:
now we religiously check the results and set errors appropriately
(this affected bmp, fits, ico, jpeg2000, sgi, targa, tiff, webp, zfile).
This work was mostly Kevin Brightwell, with a cleanup pass by Larry Gritz.