fix(sessions): allow cargo publish by renaming nested helper manifest#175
Merged
Conversation
epmog
reviewed
May 11, 2026
Cargo refuses to package any subdirectory containing a `Cargo.toml`, which caused `cargo publish -p openjd-sessions` to exclude `src/helper/` and fail during verification. Rename the helper manifest to `Cargo.toml.bundled` so Cargo includes it in the tarball, and update `build.rs` to copy the helper tree into OUT_DIR and restore the manifest name before building. Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>
epmog
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Publishing openjd-sessions to crates.io didn't work on the first try.
What was the solution? (How)
Cargo refuses to package any subdirectory containing a
Cargo.toml, which causedcargo publish -p openjd-sessionsto excludesrc/helper/and fail during verification. Rename the helper manifest toCargo.toml.bundledso Cargo includes it in the tarball, and updatebuild.rsto copy the helper tree into OUT_DIR and restore the manifest name before building.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.