fix: Run Windows Session cleanup at high priority.#173
Merged
ddneilson merged 1 commit intoOpenJobDescription:mainlinefrom Sep 19, 2024
Merged
fix: Run Windows Session cleanup at high priority.#173ddneilson merged 1 commit intoOpenJobDescription:mainlinefrom
ddneilson merged 1 commit intoOpenJobDescription:mainlinefrom
Conversation
erico-aws
force-pushed
the
increase-cleanup-prio
branch
from
a688fbc to
75c9b36
Compare
ddneilson
reviewed
Sep 18, 2024
epmog
reviewed
Sep 18, 2024
epmog
approved these changes
Sep 18, 2024
Contributor
epmog
left a comment
epmog
left a comment
There was a problem hiding this comment.
Looks good to me. Sounds like we have some future action items to update other actions, and potentially elsewhere. Ship it
ddneilson
approved these changes
Sep 19, 2024
Signed-off-by: Eric Osiowy <134728121+erico-aws@users.noreply.github.com>
ddneilson
force-pushed
the
increase-cleanup-prio
branch
from
75c9b36 to
aee54d1
Compare
|
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
During session cleanup, the powershell Remove-Item command can get starved for cycles if there's another process consuming too much of the CPU.
What was the solution? (How)
Have the cleanup command run at a higher priority.
What is the impact of this change?
An important task, like session clean up, should be prioritized. This allows clean up to happen when it otherwise might not.
How was this change tested?
This change was tested in the context of a Deadline Cloud Worker Agent. My CMF was running a CPU heavy workload. I observed in the session logs that clean up completed quickly during a cancelation. Prior to my change, a cancelation was taking > 5 min.
Was this change documented?
No
Is this a breaking change?
No.
Does this change impact security?
No.