Get rid of CL_DEVICE_TYPE_CUSTOM #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @xlz @christiankerl |
Member
|
this is ok. Opencl needs two other fixes. First, get cmake's latest findopencl.cmake instead of ours. Second, include cl.hpp, so no more mac osx hack is needed, and also Debian's opencl-headers no longer has cl.hpp. These two have liberal licenses and no licensing problem, but perhaps you want a separate file to list their licenses for the ease of redistribution. |
Contributor
Author
|
FindOpenCL.cmake is part of cmake 3.x, but we require only cmake 2.8.something, so it might not be backwards-compatible? |
Member
|
It looks like all modules used in FindOpenCL.cmake (CheckSymbolExists, CMakePushCheckState, FindPackageHandleStandardArgs) are available as early as 2.8.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused several issues with older OpenCL SDKs, can be removed safely.