makes the map for storing the color offset for each depth pixel a function parameter in order to make the user decide the allocation policy #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2015 10:42
…ction parameter in order to make the user decide the allocation policy
src/registration.cpp
Outdated
Member
There was a problem hiding this comment.
bigdepth -> color_depth_map. And its required size?
Contributor
|
Since this doesn't really change the interface or the internal operation and just provides an option which some people may find useful, I'll include this for 0.2. |
Author
|
Thanks |
Member
|
This breaks the ABI. If this is to be merged, it is before 0.1. |
Contributor
|
OK, not a problem. Fine for 0.1, too. |
floe
added a commit
that referenced
this pull request
Nov 27, 2015
add external allocation parameter for color offset map
Contributor
|
Hi I think there's an issue on this commit, it appears that the method apply() of class RegistrationImpl is missing the parameter color_depth_map. |
ludiquechile
added a commit
to ludiquechile/libfreenect2
that referenced
this pull request
Nov 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the map for storing the color offset for each depth pixel a function parameter in order to make the user decide the allocation policy