Cross-platform shortcuts, onboarding, and build#9
Cross-platform shortcuts, onboarding, and build#9kesku wants to merge 5 commits intoOpenKnots:mainfrom
Conversation
Replace macOS-only shortcut labels across onboarding, welcome states, overlays, and tooltips so Windows and Linux users see platform-correct guidance throughout the app.
Update the desktop docs and README to describe Windows, macOS, and Linux support consistently, including platform-neutral shortcut guidance and install notes.
Use cross-env for desktop commands and teach the secrets scan hook to find winget-installed gitleaks so builds and commits work on Windows.
Resolve conflicts in DEVELOPMENT.md and package.json: keep cross-platform build and shortcut docs, cross-env desktop scripts, and bash-based secrets scan; add upstream policy:skill-first scripts.
BunsDev
left a comment
BunsDev
left a comment
There was a problem hiding this comment.
Holding this for two reasons. First, GitHub already marks the branch conflicting, so it needs a rebase before merge. Second, lib/platform.ts currently falls back to 'windows' when navigator is unavailable. In this Next.js app that means prerendered UI can emit Windows shortcut labels on non-Windows platforms and then change after hydration anywhere formatShortcut() is used. Please make the shortcut rendering hydration-safe before rebasing this for merge.
|
Closing this as superseded by #15. The useful cross-platform pieces were rebuilt on top of current main, but the runtime platform-label path from this branch was intentionally replaced with hydration-safe generic shortcut labels () and the build/package changes were rebased into the new implementation. |
2 participants
Type
feat— new featurefix— bug fixdocs— documentation onlychore— maintenance / dependenciesrefactor— code change (no new feature, no bug fix)test— adding or updating testsWhat
Makes shortcuts, onboarding, and docs platform-aware (Windows / macOS / Linux) and fixes desktop build and pre-commit hooks on Windows so the app and contributor workflow work correctly on all supported platforms
Why
Onboarding and UI showed macOS-only shortcut labels (e.g. ⌘) on Windows and Linux, and the build/hooks assumed Unix paths and tools
Testing
pnpm checkpassespnpm testpassesScreenshots
Before:
After: