Skip to content

Add initial Windows port for the desktop app#26

Closed
Jonohobs wants to merge 2 commits intoOpenKnots:mainfrom
Jonohobs:fix/windows-desktop-ci
Closed

Add initial Windows port for the desktop app#26
Jonohobs wants to merge 2 commits intoOpenKnots:mainfrom
Jonohobs:fix/windows-desktop-ci

Conversation

@Jonohobs
Copy link
Copy Markdown
Contributor

Summary

  • add an initial Windows port for the desktop app
  • add a Windows CI build that produces downloadable installer artifacts
  • make the packaging compatibility adjustments needed for the Windows build path

Notes

This PR is intended as a Windows porting contribution so the existing desktop app can also build and launch on Windows.

To get the Windows path working cleanly, I made a couple of packaging-oriented adjustments:

  • limit an unsigned Windows packaging workaround to the Windows path that needed it
  • update ICO generation so the generated Windows icon includes the higher-resolution size Electron Builder expects for Windows installers

These changes are intended to make the Windows build work reliably from source and to make that path reproducible in CI.

Windows build updates

  • add a desktop_windows job to .github/workflows/ci.yml
  • scope an unsigned packaging workaround to the Windows path only
  • disable executable editing for unsigned Windows builds
  • update scripts/generate-brand-assets.py so generated ICOs include the sizes expected by the Windows packaging toolchain
  • regenerate the affected favicon and Windows icon assets

Validation

  • built the Windows NSIS installer successfully on Windows
  • verified the installer completed and produced an installed app under %LOCALAPPDATA%\\Programs\\okcode-desktop
  • launched the installed Windows app successfully after installation
  • parsed the updated CI YAML locally

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 27, 2026

@Jonohobs is attempting to deploy a commit to the 0xBuns Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M labels Mar 27, 2026
@Jonohobs Jonohobs changed the title Add initial Windows port and CI build for the desktop app Add initial Windows port for the desktop app Mar 27, 2026
@BunsDev BunsDev self-assigned this Mar 27, 2026
@BunsDev
Copy link
Copy Markdown
Member

BunsDev commented Mar 27, 2026

Thanks for this Windows desktop port, @Jonohobs ✨ Merging it together with the Windows icon packaging fix now.

@BunsDev
Copy link
Copy Markdown
Member

BunsDev commented Mar 27, 2026

I replayed the Windows desktop changes cleanly onto current main and merged them via #32 to avoid dragging in stale branch regressions. Thanks again for the original work here, @Jonohobs

@BunsDev
Copy link
Copy Markdown
Member

BunsDev commented Mar 27, 2026

Superseded by #32, which rebased and merged the Windows desktop work cleanly onto current main. Thanks again @Jonohobs

@BunsDev BunsDev closed this Mar 27, 2026
@Jonohobs Jonohobs deleted the fix/windows-desktop-ci branch March 28, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants