Add initial Windows port for the desktop app#26
Closed
Jonohobs wants to merge 2 commits intoOpenKnots:mainfrom
Closed
Add initial Windows port for the desktop app#26Jonohobs wants to merge 2 commits intoOpenKnots:mainfrom
Jonohobs wants to merge 2 commits intoOpenKnots:mainfrom
Conversation
|
@Jonohobs is attempting to deploy a commit to the 0xBuns Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks for this Windows desktop port, @Jonohobs ✨ Merging it together with the Windows icon packaging fix now. |
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
This PR is intended as a Windows porting contribution so the existing desktop app can also build and launch on Windows.
To get the Windows path working cleanly, I made a couple of packaging-oriented adjustments:
These changes are intended to make the Windows build work reliably from source and to make that path reproducible in CI.
Windows build updates
desktop_windowsjob to.github/workflows/ci.ymlscripts/generate-brand-assets.pyso generated ICOs include the sizes expected by the Windows packaging toolchainValidation
%LOCALAPPDATA%\\Programs\\okcode-desktop