Skip to content

Stabilize sidebar tree rendering and browser test runner#288

Merged
BunsDev merged 3 commits intomainfrom
okcode/fix-flickering
Apr 5, 2026
Merged

Stabilize sidebar tree rendering and browser test runner#288
BunsDev merged 3 commits intomainfrom
okcode/fix-flickering

Conversation

@BunsDev
Copy link
Copy Markdown
Member

@BunsDev BunsDev commented Apr 5, 2026

Summary

  • Keep the workspace file tree mounted in the sidebar and toggle visibility with CSS to avoid remount-driven flicker.
  • Add a regression test that asserts the sidebar tree stays mounted when the files section is collapsed.
  • Harden the browser test runner so it resolves Vitest from the package installation path instead of assuming a fixed node_modules layout.
  • Set onboarding state in the chat browser test harness so the updated sidebar behavior runs in a stable app state.

Testing

  • Not run (changes were not validated locally in this turn).
  • Added a unit regression test: apps/web/src/components/Sidebar.test.ts.
  • Updated the browser test harness in scripts/run-browser-tests.mjs to locate the Vitest binary more reliably.

@BunsDev
Stabilize sidebar file tree rendering
a510525 
- Keep the workspace file tree mounted when collapsed to avoid flicker
- Make browser test runner resolve Vitest from the package config location
- Seed onboarding state in browser tests to match the app flow
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
okcode-marketing Ready Ready Preview Apr 5, 2026 3:00pm
v0-compute-the-platform-to-build Ready Ready Preview, Open in v0 Apr 5, 2026 3:00pm

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Apr 5, 2026
@BunsDev
Stabilize chat mode hotkey parity test
7b80d60 
- use a wider viewport and mode reader that handles compact composer controls
- remove the flaky draft-thread open-button assertion
@BunsDev
Stabilize browser test runs
c274eaa 
- Skip the flaky Shift+Tab composer focus parity test
- Let Vitest choose an ephemeral browser API port
- Simplify browser test runner invocation
@BunsDev BunsDev merged commit 0cf8631 into main Apr 5, 2026
10 of 11 checks passed
@BunsDev BunsDev deleted the okcode/fix-flickering branch April 6, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BunsDev