Add in-app browser launch for Tweakcn settings#418
Merged
Conversation
- Share URL-opening logic between GitHub links and the settings browser button - Support preview pop-out with external fallback when in-app context is unavailable
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openUrlInAppBrowserhelper to open URLs in the desktop preview when thread context is available, pop the preview out when requested, or fall back to the external browser.https://tweakcn.comin the in-app browser with a fallback to the system browser.Testing
apps/web/src/lib/openUrlInAppBrowser.test.tsfor preview, pop-out, and external open behavior.