Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the
npm run, the whole Headstart folder was served as static, which caused a reload on any file change.This issue has started happening with the new Webpack - it was either a mistake I made during the migration, or the new Webpack simply doesn't ignore changes on some static-served files, such as .git.
I fixed that by setting only the examples/ folder as static.
This change doesn't have any impact on the deployment - it affects purely the
npm runlocal server.For the local server, it has one consequence: the local examples are now served on the following adresses:
I added this to the READMEs.
In the main README, I also updated the info about required
nodeandnpmversions to match our recent decisions.And finally, I added myself to the project authors in the main README - or at least I hope I belong there too...? 😄