Case-aware application#151
Conversation
Once resolution reaches a regular file, preserve the remaining segments without attempting case-insensitive directory scans.
This approach makes the toolset look less like it is hanging when populating views.
…e_installation calls change_active_installation seems to loop loading which makes the current view hang for quite a while when loading initially.
currently the toolset doesn't launch in mingw
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c616773d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while True: | ||
| try: | ||
| self.ui.gameCombo.currentIndexChanged.disconnect(self.change_active_installation) | ||
| except (TypeError, RuntimeError): | ||
| break |
There was a problem hiding this comment.
Break disconnect loop when no handler is attached
_disconnect_game_combo_signal() depends on disconnect(self.change_active_installation) throwing to terminate while True, but some Qt bindings return a falsy value instead of raising when the slot is no longer connected. In that environment, this loop never exits and the UI can hang when reload_installations() or unset_installation() calls this helper. Make the loop break on a falsy disconnect result (or disconnect once) so the code works across bindings.
Useful? React with 👍 / 👎.
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
Addressed in |
|
Thanks @ProjectSynchro :) |
Description
This pull request introduces comprehensive improvements to path handling across the codebase by replacing usages of
Pathwith the customCaseAwarePathclass. This ensures robust, case-insensitive file and directory resolution—particularly important for archive files, virtual paths, and cross-platform compatibility.It also includes updated logic, expanded test coverage, cleanup of obsolete imports, and a merge-conflict resolution update to keep the branch aligned with the latest
masterchanges.Type of Change
Package(s) Affected
Tools/Changes Made
Path handling improvements
PathwithCaseAwarePathin affected modules, improving case-insensitive path resolution and support for archive files and virtual paths.CaseAwarePathfor existence checks, directory operations, and path joining.Pathin modules now fully migrated toCaseAwarePath.Archive and virtual path resolution
_resolve_pathmethod inCaseAwarePathto avoid scanning archive files for virtual segments, preventing unnecessary filesystem operations and improving performance for pseudo-paths inside archives.Testing and validation
master.test_case_aware_path.pytest_capsule.pytest_talktable.pytest_heuristics.pyBranch sync and merge resolution
master.Tools/HolocronToolsetsubmodule layout frommaster.Testing
Test Results
Checklist
Related Issues
Screenshots (if applicable)
Additional Notes
This PR now includes the merge-conflict resolution needed to keep the case-aware path work current with
master, without changing the intended functionality of the original fix.