add some operating system AMIs and URNs#11
Merged
Adamkadaban merged 6 commits intomainfrom Feb 6, 2025
Merged
Conversation
Member
Author
|
Looks like test coverage is a problem. I will push commits for #13 and add the appropriate tests. And then re-request review |
Member
Also for enums and other data definitions you can also add a directive to ignore those for test coverage since there might not be a good way to get those covered with tests. |
alexchristy
approved these changes
Feb 6, 2025
Member
alexchristy
left a comment
alexchristy
left a comment
There was a problem hiding this comment.
Changes look good on my end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Add enums and dictionaries for AWS and Azure VMs.
Includes some of:
TODO: Add OSType to openlabs spec.
Fixes: #8