Add a check that a file is in the directory it is supposed to be in#513
Merged
turkeylurkey merged 1 commit intoMay 8, 2026
Merged
Conversation
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
TrevCraw
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OpenLiberty/ci.maven#1976
This method calculates a path assuming the file is in the directory passed in. If it is not there then there is an off-by-one error and the plugin may go ahead and silently copy the file to the incorrect location.
Add an assertion when an invalid parameter is passed. Just print a traceback to the log to prompt the plugin developer to fix the bug. Should not happen in production but if it does the user can open an issue but otherwise keep working.