Update to use maven wrapper #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge staging to prod - Dependabot Bump
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
GeeTransit
approved these changes
May 21, 2025
Member
GeeTransit
left a comment
GeeTransit
left a comment
There was a problem hiding this comment.
Tested successfully on MacOS
AndrewSasmito
approved these changes
May 21, 2025
GeeTransit
approved these changes
May 22, 2025
Member
GeeTransit
left a comment
GeeTransit
left a comment
There was a problem hiding this comment.
Tested successfully on Windows, also pushed a fix for the last multiline command example (should use ^ instead of \ to continue lines, and \ instead of / in paths)
gkwan-ibm
suggested changes
May 26, 2025
Contributor
gkwan-ibm
left a comment
gkwan-ibm
left a comment
There was a problem hiding this comment.
hi @SiaaG-dev
At the Starting dev mode with run options last section, would you update the [role='command'] lines to [role="no_copy"] because don't want to mislead users to run the command?
Contributor
|
hi @SiaaG-dev Also update the |
Member
Author
|
yes, I will update these |
gkwan-ibm
approved these changes
May 26, 2025
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.12.2 to 5.13.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.12.2...r5.13.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.13.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.12.2 to 5.13.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.12.2...r5.13.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.13.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…unit.jupiter-junit-jupiter-5.13.0 Bump org.junit.jupiter:junit-jupiter from 5.12.2 to 5.13.0 in /start
…junit.jupiter-junit-jupiter-5.13.0 Bump org.junit.jupiter:junit-jupiter from 5.12.2 to 5.13.0 in /finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address issue OpenLiberty/guides-common#116