Skip to content

fix(doubao_new): remove temp file after cross-storage put#2530

Merged
Suyunmeng merged 1 commit into
mainfrom
fix/cache
May 27, 2026
Merged

fix(doubao_new): remove temp file after cross-storage put#2530
Suyunmeng merged 1 commit into
mainfrom
fix/cache

Conversation

@Suyunmeng

Copy link
Copy Markdown
Contributor

Summary / 摘要

  • Fixed a bug where cross-storage copy uploads to Doubao New could leave temp/file-* temporary files after upload completion.

  • In drivers/doubao_new/driver.go, the upload temp file created via utils.CreateTempFile is now always cleaned by defer with Close + Remove.

  • User-visible behavior change: after copy tasks complete, temporary files generated for this upload path are cleaned up, preventing Temp directory growth and disk exhaustion.

  • Important implementation note: no upload protocol logic was changed; this is a lifecycle cleanup fix only.

  • Scope note: this PR does not introduce a global upload framework change; existing drivers that use os.CreateTemp were checked and already perform Close + Remove in defer.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。

  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。

  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend:
  • OpenList-Docs:

Related Issues / 关联 Issue

Fixes #2529

Testing / 测试

  • go test ./...
  • Targeted test: go test ./drivers/doubao_new
  • Manual test / 手动测试:
    Not executed in this change set.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

@Suyunmeng Suyunmeng requested review from j2rong4cn, jyxjjj and xrgzs May 27, 2026 05:53
@Suyunmeng Suyunmeng merged commit 98c32d3 into main May 27, 2026
14 checks passed
@Suyunmeng Suyunmeng deleted the fix/cache branch May 27, 2026 08:49
EnterTang pushed a commit to EnterTang/OpenList that referenced this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 复制成功后未删除临时文件,导致磁盘爆满

2 participants