Skip to content

fix(archive): prefer utf-8 for non-EFS zip names#2557

Merged
j2rong4cn merged 1 commit into
OpenListTeam:mainfrom
Lanfei:main
May 31, 2026
Merged

fix(archive): prefer utf-8 for non-EFS zip names#2557
j2rong4cn merged 1 commit into
OpenListTeam:mainfrom
Lanfei:main

Conversation

@Lanfei

@Lanfei Lanfei commented May 31, 2026

Copy link
Copy Markdown
Contributor

Summary / 摘要

This PR fixes garbled filenames when previewing ZIP archives whose entries do not set the EFS flag.

Previously, OpenList always decoded non-EFS ZIP entry names with non_efs_zip_encoding (default: IBM437). In practice, some ZIP tools store filenames as valid UTF-8 but do not set the EFS flag, which caused Chinese and other non-ASCII filenames to appear garbled.

Changes in this PR:

  • Prefer the original filename when the ZIP entry has the EFS flag.
  • For non-EFS ZIP entries, return the original name first if it is already valid UTF-8.
  • Only fall back to non_efs_zip_encoding when the raw filename is not valid UTF-8.
  • Add unit tests covering:
    • valid UTF-8 names without EFS
    • fallback decoding with configured encoding
    • unchanged behavior when EFS is set

User-visible behavior:

  • ZIP preview now displays more non-EFS UTF-8 filenames correctly.
  • Legacy non-UTF-8 ZIP files still use the configured fallback encoding.

Compatibility:

  • No breaking changes.

  • No public API, config schema, storage format, or migration behavior changes.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。

  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。

  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend:
  • OpenList-Docs:

Testing / 测试

  • go test ./...
  • Manual test / 手动测试:
    • go test ./internal/archive/zip
    • Verified the updated decoding logic with unit tests for UTF-8-first fallback behavior.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

@j2rong4cn j2rong4cn merged commit 9b587ee into OpenListTeam:main May 31, 2026
14 checks passed
@jyxjjj jyxjjj mentioned this pull request Jul 1, 2026
9 tasks
EnterTang pushed a commit to EnterTang/OpenList that referenced this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants