feat(s3): support direct transfer redirects#2598
Merged
Merged
Conversation
Redirect S3 GET object requests to direct links when the underlying storage can provide one and proxying is not required. Redirect eligible S3 PUT object requests to HttpDirect single PUT upload URLs with 307, while falling back to the existing gofakes3 stream path for unsupported uploads. Allow OneDrive Sharelink direct upload info to use simple content PUT URLs for files within Microsoft's single-upload limit. Co-authored-by: Codex <codex@openai.com>
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d032dbbbb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jyxjjj
approved these changes
Jun 11, 2026
26 tasks
1 task
EnterTang
pushed a commit
to EnterTang/OpenList
that referenced
this pull request
Jul 12, 2026
Redirect S3 GET object requests to direct links when the underlying storage can provide one and proxying is not required. Redirect eligible S3 PUT object requests to HttpDirect single PUT upload URLs with 307, while falling back to the existing gofakes3 stream path for unsupported uploads. Allow OneDrive Sharelink direct upload info to use simple content PUT URLs for files within Microsoft's single-upload limit. Co-authored-by: syscc <syscc@users.noreply.github.com> Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Add an S3 HTTP wrapper that returns
302 Foundfor eligibleGET Objectrequests when the mapped OpenList storage can provide a direct download URL and proxying is not required.Add
307 Temporary Redirectsupport for eligiblePUT Objectrequests when the mapped storage supportsHttpDirectsingle-requestPUTuploads.Keep the existing gofakes3 streaming path as the fallback for unsupported cases, including multipart upload, copy requests, streaming SigV4 payloads, drivers without direct upload, forced proxy rules, chunked direct-upload sessions, and direct-upload info requiring extra headers.
Allow OneDrive Sharelink direct-upload info to use Microsoft Graph simple
/contentupload URLs for files within the 250 MiB single-upload limit, so S3PUT Objectcan be redirected safely for those files.This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Testing / 测试
go test ./...go test ./server/s3 ./server/handles ./drivers/onedrive_sharelink403 InvalidAccessKeyId.GET Objectreturns302 Foundwith a direct OneDrive Sharelink download URL.GET Object?x-id=GetObjectalso returns302 Found.PUT Objectto OneDrive Sharelink returns307 Temporary Redirectwith a direct Graph/contentupload URL for a small file.PUT Objectto 189CloudPC falls back to the existing server-side upload path and succeeds with200 OK.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。