refactor(func): replace GinWithValue with GinAppendValues#2475
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames GinWithValue to GinAppendValues and changes its semantics so that values appended to the request context are visible through previously-held context references (mutating an embedded context.Context inside a new requestContext wrapper instead of replacing c.Request with a brand-new immutable context chain). All call sites in server/ are updated. The PR also includes an unrelated refactor of Cloud189PC.Put upload-method dispatch in drivers/189pc/driver.go.
Changes:
- Introduce
requestContextwrapper andGinAppendValues(replacingGinWithValue); renameContentWithValuetoContentWithValues. - Update all middleware and handler call sites under
server/to useGinAppendValues. - Unrelated: restructure
Cloud189PC.Putupload-method selection and remove a duplicate秒传 branch.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/common/common.go | New requestContext + GinAppendValues with mutable-context semantics; rename helper to ContentWithValues. |
| server/webdav.go | Switch all GinWithValue calls to GinAppendValues. |
| server/middlewares/auth.go | Same call-site rename across Auth/Authn. |
| server/middlewares/check.go | Rename in StoragesLoaded. |
| server/middlewares/down.go | Rename in PathParse and Down. |
| server/middlewares/sharing.go | Rename in SharingIdParse/EmptyPathParse. |
| server/handles/fsread.go | Rename in FsList/FsDirs/FsGet/FsOther. |
| server/handles/fsmanage.go | Rename in FsRemoveEmptyDirectory. |
| server/handles/fsbatch.go | Rename in FsRecursiveMove/FsBatchRename/FsRegexRename. |
| server/handles/archive.go | Rename in FsArchiveMeta/FsArchiveList. |
| drivers/189pc/driver.go | Unrelated Put dispatch refactor; comment typo "妙传". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PIKACHUIM
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
原本
GinWithValue是用来代替Gin.Set方法的,现在改成更合适的GinAppendValuesMotivation and Context / 背景
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。