fix(offline_download): fix login failure caused by qBittorrent 5.2.0 returning HTTP 204 No Content on successful authentication#2476
Merged
Conversation
…returning HTTP 204 No Content on successful authentication
yuanczx
commented
May 16, 2026
Contributor
Author
yuanczx
left a comment
There was a problem hiding this comment.
qBittorrent 5.2.0 now returns 204 No Content when when response contains no data, so we should also treat 204 as a successful response here.
Ref: WebAPI changelog
Member
|
Related: #2248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(offline_download): fix login failure caused by qBittorrent 5.2.0 returning HTTP 204 No Content on successful authentication
Description / 描述
Fix qBittorrent login failure when using version 5.2.0 or later.
Starting from qBittorrent 5.2.0, the WebUI login API returns
204 No Contenton successful authentication instead of200 OKwith "Ok" response body. This causes the current client implementation to fail with an EOF error when reading the empty response body.Motivation and Context / 背景
The current qBittorrent client implementation expects login success to return status code 200 with "Ok" response body. However, qBittorrent 5.2.0 returns 204 No Content with an empty body, causing:
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。