Skip to content

fix(security): driver uncontrolled data used in path expression injection #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odaysec wants to merge 2 commits into from
Closed

fix(security): driver uncontrolled data used in path expression injection #740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e8dd9
Update driver.go
odaysec Jul 17, 2025
443fbd2
Update drivers/local/driver.go
odaysec Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/local/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ func (d *Local) Link(ctx context.Context, file model.Obj, args model.LinkArgs) (
}

func (d *Local) MakeDir(ctx context.Context, parentDir model.Obj, dirName string) error {
// Validate dirName to ensure it does not contain invalid characters
if filepath.Base(dirName) != dirName {
return fmt.Errorf("invalid directory name: %q", dirName)
}
fullPath := filepath.Join(parentDir.GetPath(), dirName)
err := os.MkdirAll(fullPath, os.FileMode(d.mkdirPerm))
if err != nil {
Expand Down