Replace remaining users of var_83C with rowCount#3709
Merged
AaronVanGeffen merged 3 commits intoOpenLoco:masterfrom Apr 23, 2026
Merged
Replace remaining users of var_83C with rowCount#3709AaronVanGeffen merged 3 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 3 commits intoOpenLoco:masterfrom
Conversation
| int16_t rowInfo[1000]; | ||
| uint16_t rowCount; | ||
| uint16_t var_83C; | ||
| uint16_t var_83C; // unused |
Contributor
There was a problem hiding this comment.
perhaps we could say was used in conjuction with rowCount to represent displayed rows.
duncanspumpkin
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the various 'list' windows recently refactored, the
var_83Cis now hardly used. This PR replaces the two remaining instances (build vehicle, terraform/trees) withrowCountas well. Makes things just a little bit more readable.