Proper error handling of convert engine command when file does not exist#1099
Open
hschilling wants to merge 12 commits intoOpenMDAO:mainfrom
Open
Proper error handling of convert engine command when file does not exist#1099hschilling wants to merge 12 commits intoOpenMDAO:mainfrom
hschilling wants to merge 12 commits intoOpenMDAO:mainfrom
Conversation
…t might exist inside the Aviary repo. Need to check for file existence on convert_engine_deck now since get_path did that for us
…-convert-engine-error-message
…ns depend on that
Member
Kenneth-T-Moore
left a comment
There was a problem hiding this comment.
Looks good, but probably should add a test for the two new error messages.
…-convert-engine-error-message
…-convert-engine-error-message
…ists if relative to the Aviary module path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current behavior is that if a user does this command and the file
turbofan_23k_1.engdoes not exist in the current working directorythey get an error
This is because behind the scenes, Aviary searches for the file
turbofan_23k_1.engand any files "like" it to use as the input file. It findsand tried to convert that, which fails.
This PR changes that behavior by not searching for a similar file. If the file requested does not exist, the user gets an error message saying it doesn't exist and the command fails.
Related Issues
Backwards incompatibilities
None
New Dependencies
None