Skip to content

Engine deck conversion update#747

Merged
jkirk5 merged 15 commits intoOpenMDAO:mainfrom
jkirk5:engine_conversion
May 30, 2025
Merged

Engine deck conversion update#747
jkirk5 merged 15 commits intoOpenMDAO:mainfrom
jkirk5:engine_conversion

Conversation

@jkirk5
Copy link
Copy Markdown
Contributor

@jkirk5 jkirk5 commented Apr 22, 2025

Summary

Testing of engine conversion was broken, never actually checking data. Converter utility as it currently existed produced different results than what was actually present (different number of generated points).

  • Reverted some converter settings to their original values, which can reproduce our original Aviary engine decks (number of generated points in those decks was intended behavior)
  • Added in optional rounding of engine deck values when converting. Engine decks inside models were either re-converted if old data still available, or just re-formatted & rounded without otherwise changing data for better human readability.
  • Updated tests that changed with these new rounded engine decks. Typically changes are extremely minor and only break very tight tolerance tests

Related Issues

  • Resolves #

Backwards incompatibilities

Will very slightly change results for any model that uses the built-in engine decks. This PR may want to wait for 0.10.1+

New Dependencies

None

Comment thread aviary/utils/engine_deck_conversion.py Outdated
@jkirk5 jkirk5 merged commit 53e782d into OpenMDAO:main May 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants