Engine deck conversion update#747
Merged
jkirk5 merged 15 commits intoOpenMDAO:mainfrom May 30, 2025
Merged
Conversation
Kenneth-T-Moore
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing of engine conversion was broken, never actually checking data. Converter utility as it currently existed produced different results than what was actually present (different number of generated points).
Related Issues
Backwards incompatibilities
Will very slightly change results for any model that uses the built-in engine decks. This PR may want to wait for 0.10.1+
New Dependencies
None