Split EquipAndUsefulLoadMass component#753
Merged
jkirk5 merged 9 commits intoOpenMDAO:mainfrom May 19, 2025
Merged
Conversation
…ses and ther other for useful load. Move air condition mass and furnishing mass out from equipment masses.
jkirk5
approved these changes
May 5, 2025
Kenneth-T-Moore
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR split EquipAndUsefulLoadMass component into several smaller components:
There was an error in
equipment_and_useful_load.pywhere~is used. This PR fixed this error by replacing it withnot.This was an earlier effort to override certain values. For example, if
Aircraft.Furnishings.MASSis set to a non-zero value, this value is used instead of empirical mass equation.The bigger problem is that all 9 unit tests set those variables to non-zero values. So, if we remove this naive override code, all the tests in
test_mass_summation.pyfail. Even worse: some will result inNaNerror. It is worth to mention that furnishing mass is a significant large number. In those test runs, the computed value of furnishing mass is 17122 lbm while the give mass is 11192 lbm in test 1 through 6; the computed value of furnishing mass is 14043 lbm while the give mass is 9114 lbm in test 7 through 9. With such big differences, we sure get quit different overall mass results.Related Issues
Backwards incompatibilities
None
New Dependencies
None