Fix bug that broke preprocessing of crew options.#761
Conversation
| @@ -71,6 +72,7 @@ def create_vehicle(vehicle_deck='', meta_data=_MetaData, verbosity=Verbosity.BRI | |||
| verbosity = Verbosity.BRIEF | |||
|
|
|||
| aircraft_values = get_option_defaults(engine=False) | |||
There was a problem hiding this comment.
I'm not really sure why we're loading all the defaults to begin with, it doesn't seem like this is very helpful anymore. Maybe we should consider skipping this step in the future, which should remove the need for remove_preprocessed_options
There was a problem hiding this comment.
That is a good point. I am not sure why we pre-load those into the aviary_options. All of the defaults are also present in the options dictionaries, so they get set correctly even without this step. Maybe there is something on the GASP side that isn't doing that.
| aircraft:crew_and_payload:mass_per_passenger,165,lbm | ||
| aircraft:crew_and_payload:misc_cargo,0,lbm | ||
| aircraft:crew_and_payload:non_flight_crew_mass_scaler,1,unitless | ||
| aircraft:crew_and_payload:num_business_class,20,unitless |
There was a problem hiding this comment.
You shouldn't have to add these passenger values because they should be automatically setup based on the design values. I think you can remove these 4 lines of changes.
There was a problem hiding this comment.
I added these because they weren't getting set right, which must mean that a new bug has cropped up.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 participants
Summary
Certain keys need to remain empty so that the preprocessor knows when to set them.
Bonus: Fix for failing IPOPT bench.
Related Issues
Backwards incompatibilities
None
New Dependencies
None