Adding unit tests for GASP based premission#787
Merged
jkirk5 merged 20 commits intoOpenMDAO:mainfrom Jun 23, 2025
Merged
Conversation
…nto test_gasp_premission
…nto test_gasp_premission
Kenneth-T-Moore
approved these changes
Jun 16, 2025
…nto test_gasp_premission
jkirk5
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part of ongoing BWB task and so it is optional.
We have unit test for FLOPS based unit tests but never have one for GASP based. Two unit tests are added using
models/test_aircraft/aircraft_for_bench_GwGm.csv: one for default premission: propulsion + geometry + aerodynamics + mass and the other for geometry + mass. When propulsion and aerodynamics are not in, the following two variables must be defined:Aircraft.Engine.SCALED_SLS_THRUSTMission.Landing.LIFT_COEFFICIENT_MAXRelated Issues
Backwards incompatibilities
None
New Dependencies
None