gaspaero modification in preparation for BWB#791
Merged
jkirk5 merged 25 commits intoOpenMDAO:mainfrom Jun 30, 2025
Merged
Conversation
minor update
xjjiang
changed the title
Add a comment in LiftCoeff class.
removed my comment.
Contributor
|
Awaiting more changes - not ready for merge quite yet |
Contributor
Author
It is ready for review now. @jkirk5 |
jkirk5
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of BWB task and is optional. There are two new classes:
FormFactorAndSIWBbody_form_factorsiwbGroundEffectkclgeFormFactorAndSIWBclass was part ofAeroGeomclass.GroundEffectclass was part ofLiftCoeff.Currently,
LiftCoeffcomputesCL_baseand updateCLin a seprate ExecComptotal_clinLowSpeedAerogroup. This setting is not appropriate for BWB task. As a result,total_clis removed andCLcomputation is moved intoLiftCoeffclass.Unit tests for
LiftCoeffandLiftCoeffCleanare added. Partials in these two classes are added.All the bench tests should remain the same.
Related Issues
Backwards incompatibilities
None
New Dependencies
None