Fixes a bug where GASP horizontal and vertical tail areas couldn't be overriden.#798
Conversation
|
In |
| aircraft:fuselage:seat_width,20.2,inch | ||
| aircraft:fuselage:tail_fineness,3,unitless | ||
| aircraft:fuselage:wetted_area,4000,ft**2 | ||
| aircraft:horizontal_tail:area,355.0,ft**2 |
There was a problem hiding this comment.
Why is it removed even when it is not zero?
There was a problem hiding this comment.
Hey, Xun. I removed this because the problem is using the gasp mission, and seems to work better with the gasp-computed tail value instead of the one from the FLOPS input file. Note that, due to the bug, override wasn't working for the GASP empennage, so the 355 value was being ignored.
| import openmdao.api as om | ||
|
|
||
| from aviary.variable_info.functions import add_aviary_input, add_aviary_option | ||
| from aviary.variable_info.functions import add_aviary_input, add_aviary_output, add_aviary_option |
There was a problem hiding this comment.
Should we list them in alphabetic order?
There was a problem hiding this comment.
Yeah, i will fix that on whatever PR i submit next.
| 'horizontal tail. Wing span for a vertical tail.' | ||
| ), | ||
| ) | ||
| add_aviary_input(self, self.io_names['wing_ref'], val=12.612, units='ft') |
There was a problem hiding this comment.
I think it will be good to keep the description so that some history is not lost. Same comment applies to other variables.
There was a problem hiding this comment.
I guess this is a good point that there is some value to keeping some of the descriptive text from the generic "sizing" component.
3 participants
Summary
Fixes a bug where GASP horizontal and vertical tail areas couldn't be overriden.
Related Issues
Backwards incompatibilities
None
New Dependencies
None