Cleaned up Examples#800
Merged
jkirk5 merged 37 commits intoOpenMDAO:mainfrom Jul 7, 2025
Merged
Conversation
| ) | ||
| from aviary.interface.default_phase_info.two_dof import phase_info as default_2DOF_phase_info | ||
| from aviary.interface.default_phase_info.two_dof_fiti import ( | ||
| from aviary.models.missions.default_phase_info.two_dof import phase_info as default_2DOF_phase_info |
Member
There was a problem hiding this comment.
the missions directory only contains a phase_info directory, so I think we could move all the files up. Maybe just make the dir "mission_phase_info".
Contributor
Author
There was a problem hiding this comment.
I assume at some point we might have other missions besides the defaults, but I could just change the filenames to have the word "default" in them to avoid confusion without adding another directory
Contributor
Author
There was a problem hiding this comment.
Made that suggested change & added "default" to file names
Member
|
merging in #802 should help the failing CI. |
Kenneth-T-Moore
approved these changes
Jun 26, 2025
…er partial match.
Small fix for get_model so that it prioritizes full filename match ov…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified and streamlined the example problems available with Aviary. The goal is to have each example provide a complete (and working) problem that demonstrates a single feature. There should be as few examples as possible to teach those features.
This PR is mostly targeted at the actual python scripts in the repo, and docs changes will come as a follow-on
Removed Files
Renames
.csvfile extensions instead of arbitrary extensions such as.deck,.prop,.map, etc. so they can be recognized and opened by other programsReorganization
Related Issues
Backwards incompatibilities
None
New Dependencies
None