Aviary group rework 1#803
Merged
jkirk5 merged 44 commits intoOpenMDAO:mainfrom Jul 8, 2025
Merged
Conversation
jkirk5
requested changes
Jul 2, 2025
| pass | ||
|
|
||
| def add_post_mission_systems(self, prob): | ||
| def link_phases_helper_with_options(self, aviary_group, phases, option_name, var, **kwargs): |
Contributor
There was a problem hiding this comment.
Why is this no longer a private method? It's never used outside of the problem_configurator as far as I can tell
Contributor
Author
There was a problem hiding this comment.
link_phases_helper_with_options is used in all 3 problem configurators. These all inherit from problem_configurator. Originally this method was kept in M4L2, but it didn't make much sense to keep it there.
Kenneth-T-Moore
approved these changes
Jul 2, 2025
… mission.utils.py
…named to utils.py
fixed typo and minor formatting
jkirk5
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forwarded a number of functions from methods_for_level2 into AviaryGroup without changing top-level user interface. Pushing these functions down one level into prob.model will enable the first step to re-modelling core aviary to be more flexible to multi-mission analysis. Some methods were moved to utilities, and some small temporary changes were added to report generation to prevent that from breaking. Objective function declaration was removed from all problem_configurator files because the ODE method does not necessarily correspond with a specific objective function. For methods that remain in methods_for_level2 (alternative / fallout missions / objectives), some of them were modified to use prob.model instead of prob.
Some secondary effects of these changes. There were 'fake' aviary problems (essentially just OpenMDAO groups) setup in onboarding_for_level2.ipynb, one of which was maintained, but the other proved too convoluted to rehab to the new standard.
Related Issues
N/A
Backwards incompatibilities
None
New Dependencies
None