Post revamp payload range#812
Merged
jkirk5 merged 59 commits intoOpenMDAO:mainfrom Aug 7, 2025
Merged
Conversation
…vamp-payload-range
…1/Aviary into post-revamp-payload-range
cmbenne3
reviewed
Jul 15, 2025
adds payload_range input check Co-authored-by: Jason Kirk <110835404+jkirk5@users.noreply.github.com>
…1/Aviary into post-revamp-payload-range Merges from upstream
Kenneth-T-Moore
approved these changes
Jul 28, 2025
jkirk5
reviewed
Jul 30, 2025
| range_2 = float(self.get_val(Mission.Summary.RANGE)[0]) | ||
|
|
||
| # check if fuel capacity does not exceed sizing mission design gross mass | ||
| gross_mass = float(self.get_val(Mission.Summary.GROSS_MASS)[0]) |
Contributor
There was a problem hiding this comment.
Suggested change
| gross_mass = float(self.get_val(Mission.Summary.GROSS_MASS)[0]) | |
| gross_mass = float(self.get_val(Mission.Design.GROSS_MASS)[0]) |
If you run payload-range after running a different off-design mission you might pull the wrong mass here if you don't specifically call for design? Just covering an edge case
Contributor
Author
There was a problem hiding this comment.
The function checks that the mission the payload/range is being ran on is a sizing mission and would disallow the user from attempting it. Therefore this edge case, I don't believe is possible anymore.
jkirk5
approved these changes
Jul 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary of PR.
Adds payload range functionality through a toggle within csv file, settings:payload_range,true. As well as rewrites the run_off_design_example.py for convergence.
Related Issues
Backwards incompatibilities
None
New Dependencies
None