Phase info Revamp 4: propagate changes into the 2dof and solved2dof phases.#816
Phase info Revamp 4: propagate changes into the 2dof and solved2dof phases.#816jkirk5 merged 27 commits intoOpenMDAO:mainfrom
Conversation
…nto phase_info_revamp4
| ): | ||
| if self.phase_info[phase_name]['user_options'].get( | ||
| 'ground_roll' | ||
| ) and not self.phase_info[phase_name]['user_options'].get('rotation'): |
There was a problem hiding this comment.
Was this intentional? This is pretty different behavior and I'm not sure I follow the new logic
There was a problem hiding this comment.
Fix initial is gone now, and it was used here to indicate that the first phase is the one we are trying to select with this 'if' statement. There are 2 takeoff phases that have ground_roll, and the first one does not have rotation, so it matches the same phase.
I could probably do the same thing by checking idx == 0 instead, which is a more direct way to find the first phase.
| # This is test data generated using write_data_file | ||
| # Aviary data tables can support multiple comments | ||
|
|
There was a problem hiding this comment.
Why were the comments removed? The docs read & print these out to demonstrate how comments are stored, so we need them.
There was a problem hiding this comment.
Actually, since this file gets written by the docs themselves, it should probably be deleted entirely
There was a problem hiding this comment.
yeah, I think an earlier PR must have inserted these comments into the auto-generated file. We only see the change because I built the docs while working this PR.
2 participants
Summary
Phase info Revamp 4: propagate changes into the 2dof and solved2dof phases.
Related Issues
Backwards incompatibilities
None
New Dependencies
None