Remove inclusion of all defaults in aviary_inputs#819
Merged
Kenneth-T-Moore merged 11 commits intoOpenMDAO:mainfrom Aug 13, 2025
Merged
Remove inclusion of all defaults in aviary_inputs#819Kenneth-T-Moore merged 11 commits intoOpenMDAO:mainfrom
Kenneth-T-Moore merged 11 commits intoOpenMDAO:mainfrom
Conversation
Member
|
Is this missing the actual removal of the set defaults? |
Contributor
Author
I found out the actual changes on my local branch were unpushed. Fixed up the remaining tests and it is ready for review now |
| types=AviaryValues, | ||
| desc='collection of Aircraft/Mission specific options', | ||
| ) | ||
| add_aviary_option(self, Aircraft.LandingGear.DRAG_COEFFICIENT) |
Member
There was a problem hiding this comment.
Oh, this is one I missed.
Kenneth-T-Moore
approved these changes
Aug 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed code that adds all defaults to the AviaryProblem's
aviary_inputsduring the callload_inputs(). These defaults are now handled directly by OpenMDAO for Aviary inputs/outputs. By removing these defaults, it is now possible to know if a variable was requested by the user (and happened to be the default value) vs. the user not specifying, knowledge of which is important to fix several bugs in the code.Some variables still require hardcoded setting as they are directly called for by the AviaryProblem/AviaryGroup. They can likely be removed if there are checks that the variable exists first in the code that needs those values
Related Issues
Backwards incompatibilities
None
New Dependencies
None