Update fortran_to_aviary for BWB model

[xjjiang]

Summary

Update the settings of Aviary variables to match with GASP descriptions and default values.

Related Issues

• Resolves #

Backwards incompatibilities

None

New Dependencies

None

[xjjiang]

@jkirk5 @Kenneth-T-Moore , One thing that I am concerned but not touched is the size of aviary/utils/legacy_code_data/gasp_defaults.py. There are more than 150 default values. It means that Aviary adds those variables to user's model but they may not even notice them.

[Kenneth-T-Moore]

@jkirk5 @Kenneth-T-Moore , One thing that I am concerned but not touched is the size of aviary/utils/legacy_code_data/gasp_defaults.py. There are more than 150 default values. It means that Aviary adds those variables to user's model but they may not even notice them.

Does the Fortran version of Gasp also have all of these built-in defaults?

I agree that we should migrate whatever we can into the gasp aircraft input files.

[xjjiang]

@jkirk5 @Kenneth-T-Moore , One thing that I am concerned but not touched is the size of aviary/utils/legacy_code_data/gasp_defaults.py. There are more than 150 default values. It means that Aviary adds those variables to user's model but they may not even notice them.

Does the Fortran version of Gasp also have all of these built-in defaults?

I agree that we should migrate whatever we can into the gasp aircraft input files.

Some of them have defaults in GASP. Even if the defaults are the same as in GASP, it may not be true because GASP documented defaults may not be the same as in the code. I will take a look and see if I can do something.

[xjjiang]

@jkirk5 @Kenneth-T-Moore : I removed the line aircraft:engine:scale_factor,0.6824747298710352,unitless in aviary/models/aircraft/blended_wing_body/generic_BWB_GASP.csv in order that the bench test for BWB passes. It was added by fortran_to_aviary.py. I am not sure why it causes problem for test_bwb_GwGm.py to run. Do you know why?

[jkirk5]

@jkirk5 @Kenneth-T-Moore : I removed the line aircraft:engine:scale_factor,0.6824747298710352,unitless in aviary/models/aircraft/blended_wing_body/generic_BWB_GASP.csv in order that the bench test for BWB passes. It was added by fortran_to_aviary.py. I am not sure why it causes problem for test_bwb_GwGm.py to run. Do you know why?

I figured out why this is happening - in the gasp_defaults.py file INGASP.FN_REF has a value of 28690 lbf (which seems to be completely made up, since a comment mentions that variable may not even exist in GASP). The converter then sees that values for both scaled thrust and reference thrust exists, so it calculates the scale factor needed. That scale factor is based on the fake default value so it just screws the model up.

Both the fake GASP default, and the entire part of fortran_to_aviary.py that computes the scale factor (update_aviary_options()) should get removed. The preprocessors already do the scale factor calculation.