FLOPS based geometry modified#864
Merged
jkirk5 merged 21 commits intoOpenMDAO:mainfrom Sep 12, 2025
Merged
Conversation
jkirk5
approved these changes
Sep 11, 2025
Contributor
jkirk5
left a comment
There was a problem hiding this comment.
Single question to double check a variable rename, but otherwise good to go!
Kenneth-T-Moore
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In FLOPS based geometry:
CharacteristicLengthscomponent toWingCharacteristicLengthandOtherCharacteristicLength;_Fuselagecomponent to_Fuselageand_FuselageRatios.The purpose is to reuse the code as much as possible when BWB computation is added.
In FLOPS based geometry, there is no fuselage layout computation. If fuselage length or passenger compartment length is not given, it has to be computed using GASP based geometry. Now, there are two fuselage layout computations:
SimpleCabinLayoutandDetailedCabinLayout.SimpleCabinLayoutallows users to compute compartment length when fuselage length is given. If both compartment length and fuselage length are not given, they can be computed usingDetailedCabinLayout.There is no BWB component added yet.
Related Issues
Backwards incompatibilities
None
New Dependencies
None