Skip to content

FLOPS based geometry modified#864

Merged
jkirk5 merged 21 commits intoOpenMDAO:mainfrom
xjjiang:FLOPS_geom_mod
Sep 12, 2025
Merged

FLOPS based geometry modified#864
jkirk5 merged 21 commits intoOpenMDAO:mainfrom
xjjiang:FLOPS_geom_mod

Conversation

@xjjiang
Copy link
Copy Markdown
Contributor

@xjjiang xjjiang commented Aug 29, 2025

Summary

In FLOPS based geometry:

  • Split CharacteristicLengths component to WingCharacteristicLength and OtherCharacteristicLength;
  • Split _Fuselage component to _Fuselage and _FuselageRatios.

The purpose is to reuse the code as much as possible when BWB computation is added.

In FLOPS based geometry, there is no fuselage layout computation. If fuselage length or passenger compartment length is not given, it has to be computed using GASP based geometry. Now, there are two fuselage layout computations: SimpleCabinLayout and DetailedCabinLayout. SimpleCabinLayout allows users to compute compartment length when fuselage length is given. If both compartment length and fuselage length are not given, they can be computed using DetailedCabinLayout.

There is no BWB component added yet.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang marked this pull request as ready for review August 30, 2025 02:16
@xjjiang xjjiang changed the title [Draft] FLOPS based geometry modified FLOPS based geometry modified Aug 30, 2025
Copy link
Copy Markdown
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single question to double check a variable rename, but otherwise good to go!

Comment thread aviary/variable_info/variable_meta_data.py Outdated
Comment thread aviary/subsystems/geometry/flops_based/characteristic_lengths.py Outdated
Comment thread aviary/subsystems/geometry/flops_based/characteristic_lengths.py Outdated
@jkirk5 jkirk5 added this pull request to the merge queue Sep 12, 2025
Merged via the queue into OpenMDAO:main with commit 6311828 Sep 12, 2025
6 checks passed
@xjjiang xjjiang deleted the FLOPS_geom_mod branch September 12, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants