Expose primal_name to user for better support of jax aviary components.#880
Merged
jkirk5 merged 3 commits intoOpenMDAO:mainfrom Sep 18, 2025
Merged
Expose primal_name to user for better support of jax aviary components.#880jkirk5 merged 3 commits intoOpenMDAO:mainfrom
jkirk5 merged 3 commits intoOpenMDAO:mainfrom
Conversation
Contributor
|
Will there be a doc page on |
Member
Author
I think it might be a good idea for an example on how to use Jax when developing Aviary components (which for the user is probably an external subsystem.) This may require adding Jax into our CI process, at least for the doc build. |
jkirk5
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The former implementation was a little clunky, in that the user had to keep long names (like "aircraft__wing__span") in their
compute_primalcode. This change exposes the "primal_name" argument toadd_aviary_inputandadd_aviary_outputso that they can choose variable names that are more readable and maintainable.Related Issues
Backwards incompatibilities
None
New Dependencies
None