Skip to content

Expose primal_name to user for better support of jax aviary components.#880

Merged
jkirk5 merged 3 commits intoOpenMDAO:mainfrom
Kenneth-T-Moore:primal
Sep 18, 2025
Merged

Expose primal_name to user for better support of jax aviary components.#880
jkirk5 merged 3 commits intoOpenMDAO:mainfrom
Kenneth-T-Moore:primal

Conversation

@Kenneth-T-Moore
Copy link
Copy Markdown
Member

Summary

The former implementation was a little clunky, in that the user had to keep long names (like "aircraft__wing__span") in their compute_primal code. This change exposes the "primal_name" argument to add_aviary_input and add_aviary_output so that they can choose variable names that are more readable and maintainable.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang
Copy link
Copy Markdown
Contributor

xjjiang commented Sep 17, 2025

Will there be a doc page on compute_primal and primal_name?

@Kenneth-T-Moore
Copy link
Copy Markdown
Member Author

Kenneth-T-Moore commented Sep 18, 2025

Will there be a doc page on compute_primal and primal_name?

I think it might be a good idea for an example on how to use Jax when developing Aviary components (which for the user is probably an external subsystem.) This may require adding Jax into our CI process, at least for the doc build.

@jkirk5 jkirk5 added this pull request to the merge queue Sep 18, 2025
Merged via the queue into OpenMDAO:main with commit 46ec75c Sep 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants