Skip to content

Fix pre-mission to mission bus variable connection#903

Merged
Kenneth-T-Moore merged 2 commits intoOpenMDAO:mainfrom
kanekosh:fix-premission-bus
Oct 20, 2025
Merged

Fix pre-mission to mission bus variable connection#903
Kenneth-T-Moore merged 2 commits intoOpenMDAO:mainfrom
kanekosh:fix-premission-bus

Conversation

@kanekosh
Copy link
Copy Markdown
Contributor

Summary

This PR fixes the bus variable connections from pre-mission to mission that we define in get_pre_mission_bus_variables.

Currently, when we try to connect a pre-mission bus variable to a mission group's hierarchical variable (for example, a connection from premission_group.myvariable to mission_group.group1.group2.myvariable), the Dymos parameter and target definitions being setup in the aviary_group.py does not work and raise ValueError: No such ODE input: 'myvariable'.

This is because in L1144 of aviary_group.py, it overrides the mission_var_name to 'myvariable' so it can be used as a Dymos parameter name. So after L1144, we have mission_var_name = 'myvariable' and targets= 'group1.group2.myvariable'. But when we add a Dymos parameter, the target entry should include the path information, but currently it uses mission_var_name. Therefore this does not work unless myvariable is promoted to the top-level in the mission group.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@Kenneth-T-Moore
Copy link
Copy Markdown
Member

Hey, Shugo. Thanks for the fix. This was definitely a bug. Looks like CI is failing on something unrelated; i will look into that.

@Kenneth-T-Moore Kenneth-T-Moore added this pull request to the merge queue Oct 20, 2025
Merged via the queue into OpenMDAO:main with commit f575bc7 Oct 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants