Fix pre-mission to mission bus variable connection#903
Merged
Kenneth-T-Moore merged 2 commits intoOpenMDAO:mainfrom Oct 20, 2025
Merged
Fix pre-mission to mission bus variable connection#903Kenneth-T-Moore merged 2 commits intoOpenMDAO:mainfrom
Kenneth-T-Moore merged 2 commits intoOpenMDAO:mainfrom
Conversation
Member
|
Hey, Shugo. Thanks for the fix. This was definitely a bug. Looks like CI is failing on something unrelated; i will look into that. |
Kenneth-T-Moore
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bus variable connections from pre-mission to mission that we define in
get_pre_mission_bus_variables.Currently, when we try to connect a pre-mission bus variable to a mission group's hierarchical variable (for example, a connection from
premission_group.myvariabletomission_group.group1.group2.myvariable), the Dymos parameter andtargetdefinitions being setup in the aviary_group.py does not work and raiseValueError: No such ODE input: 'myvariable'.This is because in L1144 of
aviary_group.py, it overrides themission_var_nameto'myvariable'so it can be used as a Dymos parameter name. So after L1144, we havemission_var_name = 'myvariable'andtargets= 'group1.group2.myvariable'. But when we add a Dymos parameter, thetargetentry should include the path information, but currently it usesmission_var_name. Therefore this does not work unlessmyvariableis promoted to the top-level in the mission group.Related Issues
Backwards incompatibilities
None
New Dependencies
None