refactor: relocate configs and enforce import rules#158
Merged
Conversation
Frankstein73
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the configuration structure, making config classes live alongside the methods and classes that consume them. It also enforces a strict rule set for internal module imports to ensure consistency:
trainer.py): Must use absolute imports.factory.py): Use absolute imports for dependencies outside the submodule, and relative imports for internal references. Parent directory traversal (e.g.,from ..module import) is prohibited.__init__.pyfiles: Must always use relative imports.lm_saesmust use fully qualified paths. External code (e.g., server or tests) is permitted to import directly from the rootlm_saespackage.