Add iterator type aliases to ParamIterator#8362
Merged
timosachsenberg merged 3 commits intodevelopfrom Nov 12, 2025
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Add iterator_category (std::forward_iterator_tag) - Add value_type (Param::ParamEntry) - Add difference_type (std::ptrdiff_t) - Add pointer (const Param::ParamEntry*) - Add reference (const Param::ParamEntry&) - Add necessary includes (<iterator> and <cstddef>) - Add comprehensive tests for iterator traits Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make ParamIterator a real iterator by adding missing tags
Add iterator type aliases to ParamIterator
Nov 6, 2025
timosachsenberg
approved these changes
Nov 6, 2025
Contributor
timosachsenberg
left a comment
There was a problem hiding this comment.
looks good... let's wait unil mac passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParamIteratorwas missing the required type aliases (iterator_category,value_type,difference_type,pointer,reference) that enable C++ standard library algorithms to work with it viastd::iterator_traits.Changes
Param.h: Added five iterator type aliases toParamIteratorclassiterator_category = std::forward_iterator_tag(supports increment only)value_type = Param::ParamEntrydifference_type = std::ptrdiff_tpointer = const Param::ParamEntry*reference = const Param::ParamEntry&<iterator>and<cstddef>headersstd::iterator_traitsUsage
ParamIteratornow works with STL algorithms:Pattern follows existing OpenMS iterators like
IntensityIteratorWrapper.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.