Icon name should match the file name

[pjones]

Description

When building OpenMS on Windows and the source directory is on a case-sensitive file system the resource names must match the file names exactly.

Note: This change allows building on Windows when the source directory is on a case-sensitive file system. However, there are other (weird) issues that prevent having the build directory on a case-sensitive file system. I may address that in a future PR.

Summary by CodeRabbit

• Style
  • Updated resource file naming conventions for consistency across GUI applications.

[coderabbitai]

Walkthrough

Two icon resource references in RC files are updated with corrected case-sensitive filenames: toppas.ico → TOPPAS.ico and toppview.ico → TOPPView.ico. No logic or behavioral changes occur.

Changes

Cohort / File(s)	Change Summary
Icon resource filename corrections src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPAS.rc, src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPView.rc	Updated resource ID 101 icon filenames with case corrections: toppas.ico → TOPPAS.ico and toppview.ico → TOPPView.ico

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Purely cosmetic resource filename corrections with no functional impact
• Changes are identical in pattern across both files

Poem

🐰 A dash, a case—a rabbit's care,
Icons polished, names so fair,
TOPPAS gleams with pride anew,
TOPPView wears a coat of true.
✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: correcting icon resource names to match their actual file names for case-sensitive file system compatibility.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pjones-case

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b55e34 and 4be377c.

📒 Files selected for processing (2)

• src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPAS.rc (1 hunks)
• src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPView.rc (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: build-win
• GitHub Check: build-lnx-arm
• GitHub Check: build-lnx
• GitHub Check: build-and-test (ubuntu-22.04, g++, 11)
• GitHub Check: build-and-test (macos-15-intel, xcode, 16.0.0)
• GitHub Check: build-and-test (ubuntu-22.04-arm, g++, 11)
• GitHub Check: build-macos
• GitHub Check: build-and-test (windows-2022, cl.exe, 14.36)
• GitHub Check: build-and-test (macos-26, xcode, 26.0)
• GitHub Check: build-and-test (ubuntu-22.04, clang++, 15)
• GitHub Check: cppcheck-test

🔇 Additional comments (2)

src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPView.rc (1)

1-1: Icon file verified and no stale references found.

The icon file TOPPView.ico exists with the correct capitalized name at ./src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPView.ico, and no remaining references to the old lowercase toppview.ico were found in the codebase or build configuration files. The RC file change is correct.

src/openms_gui/source/VISUAL/APPLICATIONS/GUITOOLS/TOPPAS.rc (1)

1-1: TOPPAS.ico change verified as correct and complete.

The icon file exists at the correct location with the capitalized name, the RC file reference has been properly updated to TOPPAS.ico, no stale lowercase references remain anywhere in the codebase, and the change follows the established pattern used in other RC files (FLASHDeconvWizard.rc, INIFileEditor.rc, SwathWizard.rc, TOPPView.rc).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}