Skip to content

Replace boost::shared_ptr with std::shared_ptr#209

Merged
timosachsenberg merged 3 commits intostd-shared-ptrfrom
copilot/sub-pr-201
Nov 28, 2025
Merged

Replace boost::shared_ptr with std::shared_ptr#209
timosachsenberg merged 3 commits intostd-shared-ptrfrom
copilot/sub-pr-201

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Removes boost smart pointer dependency in favor of C++ standard library std::shared_ptr.

Changes

  • Replace #include <boost/shared_ptr.hpp> with #include <memory> in test headers:
    • tests/test_files/full_lib/A.hpp
    • tests/test_files/full_lib/B.hpp
    • tests/test_files/full_lib/C.hpp
    • tests/test_files/full_lib/D.hpp
    • tests/test_files/libcpp_stl_test.hpp
    • tests/test_files/libcpp_test.hpp

The code was already using std::shared_ptr—only the includes referenced the obsolete boost header.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits November 28, 2025 13:19
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove boost smart pointer and use std shared pointer Replace boost::shared_ptr with std::shared_ptr Nov 28, 2025
@timosachsenberg timosachsenberg marked this pull request as ready for review November 28, 2025 13:21
@timosachsenberg timosachsenberg merged commit 6c205de into std-shared-ptr Nov 28, 2025
4 of 26 checks passed
timosachsenberg added a commit that referenced this pull request Nov 28, 2025
* update install instructions

* Update TODO for current roadmap

* Migrate to Cython 3 only

* Remove workflow file changes

* Drop Boost smart_ptr and use std::shared_ptr

* Remove legacy shared_ptr and include_boost API parameters

Now that autowrap uses std::shared_ptr exclusively:
- Remove shared_ptr parameter from CodeGenerator.__init__ and generate_code()
- Remove include_boost parameter from generate_code(), parse_and_generate_code(),
  and Main.create_wrapper_code()
- Simplify fixed_include_dirs() and get_include_dirs() to take no arguments
- Remove include_shared_ptr attribute from CodeGenerator

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Replace boost::shared_ptr with std::shared_ptr (#209)

* Initial plan

* Replace boost/shared_ptr.hpp with memory header in test files

Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>

* Replace boost::shared_ptr with std::shared_ptr

Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>

* fix include

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants