Skip to content

Add multi-arch manifest for contrib_manylinux_2_34 images#174

Merged
timosachsenberg merged 1 commit intoOpenMS:masterfrom
timosachsenberg:fix/multiarch-manifest
Mar 9, 2026
Merged

Add multi-arch manifest for contrib_manylinux_2_34 images#174
timosachsenberg merged 1 commit intoOpenMS:masterfrom
timosachsenberg:fix/multiarch-manifest

Conversation

@timosachsenberg
Copy link
Copy Markdown
Contributor

@timosachsenberg timosachsenberg commented Mar 9, 2026

Summary

  • After building and pushing per-arch images (latest-amd64, latest-arm64), adds a create-multiarch-manifest job that combines them into a single multi-arch manifest under the base tag (e.g. latest)
  • Docker then automatically pulls the correct architecture, enabling devcontainer arm64 support

Context

Required by OpenMS/OpenMS#8862 / OpenMS/OpenMS#8740 — the devcontainer references ghcr.io/openms/contrib_manylinux_2_34:latest and relies on it being a multi-arch manifest.

Test plan

  • Trigger workflow manually via workflow_dispatch and verify the latest tag becomes a multi-arch manifest (docker manifest inspect ghcr.io/openms/contrib_manylinux_2_34:latest should show a manifest list)
  • Verify devcontainer works on both amd64 and arm64

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Enhanced deployment pipeline to automatically generate and publish multi-architecture Docker images, improving compatibility across different processor architectures and enabling deployment to diverse environments.

After building and pushing the per-arch images (latest-amd64,
latest-arm64), create a combined multi-arch manifest under the
base tag (e.g. latest). Docker then automatically pulls the
correct architecture.

This enables OpenMS/OpenMS#8740 (devcontainer arm64 support).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@timosachsenberg timosachsenberg requested a review from poshul March 9, 2026 13:57
@timosachsenberg timosachsenberg merged commit 28a7616 into OpenMS:master Mar 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1ea0447d-fbe9-462c-8a64-3f8fca9784a9

📥 Commits

Reviewing files that changed from the base of the PR and between 43611bb and 500317c.

📒 Files selected for processing (1)
  • .github/workflows/deploy-manylinux-docker.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow for deploying manylinux Docker images has been enhanced with multi-architecture manifest support. A new create-multiarch-manifest job is added that depends on the existing Deploy job, and the Deploy job now exports a tag_name output for downstream consumption.

Changes

Cohort / File(s) Summary
Workflow Multi-Arch Enhancement
.github/workflows/deploy-manylinux-docker.yml
Added create-multiarch-manifest job to publish combined multi-architecture Docker images via docker buildx imagetools create. Deploy job now exports tag_name output for use by dependent jobs. Includes Buildx setup and ghcr.io registry authentication steps.

Possibly related PRs

  • Fix git bullshit #155: Modifies the same workflow file and refactors the Deploy job structure, including architecture matrix adjustments and Dockerfile/tag logic changes.

Poem

🐰 A rabbit hops through layers of our code,
Multi-arch manifests down the deployment road,
One image for all, across every machine,
The most elegant Docker workflow you've seen!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant