Skip to content

Feature/add libcurl dependency#175

Merged
timosachsenberg merged 2 commits intomasterfrom
feature/add-libcurl-dependency
Mar 9, 2026
Merged

Feature/add libcurl dependency#175
timosachsenberg merged 2 commits intomasterfrom
feature/add-libcurl-dependency

Conversation

@timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Mar 9, 2026

Summary by CodeRabbit

  • Chores
    • Updated build dependencies to enhance application security and stability.
    • Optimized compiler settings for improved binary compatibility and cross-platform performance.

timosachsenberg and others added 2 commits March 6, 2026 09:58
OpenMS core library now uses libcurl instead of Qt Network for HTTP
operations. Add the development packages so the build can find
curl headers and libraries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add CMAKE_POSITION_INDEPENDENT_CODE=ON to the curl cmake configuration.
Without this, the static libcurl.a contains position-dependent relocations
(R_X86_64_32S) that cannot be linked into libOpenMS.so, causing linker
failures on Linux wheel builds.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@timosachsenberg timosachsenberg merged commit 59cf9fd into master Mar 9, 2026
5 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ed5c3f17-14ad-4ffe-9f28-69a0df1c9443

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab70e9 and 2856db1.

📒 Files selected for processing (2)
  • dockerfiles/Dockerfile
  • libraries.cmake/curl.cmake

📝 Walkthrough

Walkthrough

The pull request adds build dependencies for curl support by introducing the libcurl development package to the Docker image and enabling position-independent code compilation in the CMake curl build configuration, supporting curl integration in the project.

Changes

Cohort / File(s) Summary
Curl Build Integration
dockerfiles/Dockerfile, libraries.cmake/curl.cmake
Adds libcurl4-openssl-dev package to Docker dependencies and enables -D CMAKE_POSITION_INDEPENDENT_CODE=ON flag in CMake curl configuration for position-independent code compilation.

Possibly related PRs

Poem

🐰 A curl in the build, a flag set so fine,
Position-independent, the code will align,
With libcurl's embrace in the Docker we nest,
Our build now has wings—let it pass the compile test! 📦

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-libcurl-dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant