Merged
Conversation
Collaborator
singjc
commented
Apr 25, 2024
singjc
commented
- Implement plotting methods for chromatogram plotting
Merged
remove legend if only one transition color scheme set globally
add more configuration options, less hardcoding of plot aesthetics
Remove legendgrouptile and legendgroup from scatter, otherwise it groups all traces together, which then groups all traces together causing individual trace selection via legend to not work as intended. When grouped and selected all traces will be muted/hidden instead of an individual trace.
Changed lines boundaries to single rectangle boundary box because the individual lines create separate shapes which causes an issue with legend selection. If using the lines and creating two shapes, if the legend is not shown for both shapes, then only one of the lines gets hidden when the legend label is clicked. However, if both shows have the showlenged toggled on, then it creates duplicate labels for both shapes.
…nto add/chrom_plotting
…nto add/chrom_plotting Rename test jupyter notbook for 1D vis
jcharkow
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.